-
Notifications
You must be signed in to change notification settings - Fork 188
cherrypick for v1.0.7 #1793
base: release-1.0
Are you sure you want to change the base?
cherrypick for v1.0.7 #1793
Conversation
@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close now? |
Won't we cherrypick these PRs to release-1.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope there's no 1.0.8 in future 😂 And if we want to merge this PR, lots of CI work is needed
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ebcc58c
|
@GMHDBJD: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/hold waiting upgrade CI (or never) |
What problem does this PR solve?