Merge pull request #13 from rpasing/master

Mode of Generator::ircMode() and GeneratorInterface::ircMode() optional
phergie · Jul 16, 2015 · d333d7e · d333d7e
2 parents 6df0832 + 1ed6962
commit d333d7e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/Generator.php b/src/Generator.php
@@ -176,11 +176,11 @@ public function ircPart($channels, $message = null)
      * Returns a MODE message.
      *
      * @param string $target
-     * @param string $mode
-     * @param string $param
+     * @param string|null $mode
+     * @param string|null $param
      * @return string
      */
-    public function ircMode($target, $mode, $param = null)
+    public function ircMode($target, $mode = null, $param = null)
     {
         return $this->getIrcMessage('MODE', array($target, $mode, $param));
     }

diff --git a/src/GeneratorInterface.php b/src/GeneratorInterface.php
@@ -125,12 +125,12 @@ public function ircPart($channels, $message = null);
      * Returns a MODE message.
      *
      * @param string $target
-     * @param string $mode
-     * @param string $param
+     * @param string|null $mode
+     * @param string|null $param
      * @return string
      * @link https://tools.ietf.org/html/rfc2812#section-4.2.3
      */
-    public function ircMode($target, $mode, $param = null);
+    public function ircMode($target, $mode = null, $param = null);
 
     /**
      * Returns a TOPIC message.

diff --git a/tests/GeneratorTest.php b/tests/GeneratorTest.php
@@ -97,6 +97,7 @@ public function dataProviderTestGenerationMethod()
             array('ircMode', "MODE #channel :-s\r\n", array('#channel', '-s')),
             array('ircMode', "MODE #channel l :2\r\n", array('#channel', 'l', '2')),
             array('ircMode', "MODE nickname :+i\r\n", array('nickname', '+i')),
+            array('ircMode', "MODE :#channel\r\n", array('#channel')),
 
             array('ircTopic', "TOPIC :#channel\r\n", array('#channel')),
             array('ircTopic', "TOPIC #channel :topic\r\n", array('#channel', 'topic')),