ruby-version: Bump Ruby version to 3.3 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll pick this up again as part of #26. More details here: #26 (comment) |
This was referenced Jul 20, 2024
perlun
force-pushed
the
fix/upgrade-ruby-version
branch
2 times, most recently
from
2b1b8b9 to
5672dd7
Compare
perlun
force-pushed
the
fix/upgrade-ruby-version
branch
from
5672dd7 to
4472918
Compare
perlun
commented
Jul 27, 2024
| # These were previously included in Ruby, but will be removed as of Ruby 3.4 | ||
| gem 'base64', '~> 0.2.0' | ||
| gem 'bigdecimal', '~> 3.1.8' | ||
|
|
There was a problem hiding this comment.
Technically, these shouldn't be here because they are dependencies required by our dependencies. There are issues about this raised in their repos though:
- safe_yaml: Starting with Ruby 3.4.0, base64 will no longer be part of stdlib dtao/safe_yaml#108
- liquid: Ruby 3.3 deprecation warnings: base64, bigdecimal will no longer be part of the default gems Shopify/liquid#1772
If/when we upgrade to versions where these have been added to the Gemspec files, we should be able to get rid of these explicitly being listed here.
perlun
commented
Jul 27, 2024
| @@ -28,7 +28,7 @@ exclude: | |||
| languages: ["xx", "sv", "en"] | |||
| exclude_from_localizations: ["images", "public"] | |||
|
|
|||
| gems: | |||
| plugins: | |||
perlun
changed the title
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous 2.6 version we used is getting increasingly hard to install using e.g. RVM.