-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip building XS when PUREPERL_ONLY=1 set #2
base: master
Are you sure you want to change the base?
Conversation
I see there is not a CI configuration running any more (previously Travis CI). Would it help to use GitHub Actions to test this out? |
I would love a PR which test whether this provides a reasonable and working change :) |
When `PUREPERL_ONLY=1` set, this prevents the Makefile from having rules that compile the XS code. This is useful to have when building dependencies for deploying to a pure Perl install such as when using `App::FatPacker`. This removes the need to skip over files that end in `perl -V:dlext` (e.g., `.so`, `.dll`, `.dylib`) when copying to a deployment. This should allow for using the `cpanm --pureperl` option so that a pure Perl installation can be requested for all installed distributions. Signed-off-by: Zakariyya Mughal <[email protected]>
31e9276
to
4c9b0c9
Compare
Hi, if you have time, could you review this. It should be working on multiple platforms per the new CI workflow. |
@rehsack, just reaching out again about this PR. |
@rehsack, hello, do you have a moment to review this PR? |
This is to test that the tests pass as expected under various versions of Perl both using XS and pure Perl installs. Signed-off-by: Zakariyya Mughal <[email protected]>
4c9b0c9
to
3afa712
Compare
Hello @rehsack, I just ran the CI I made here again and it still passes. I also added a few more Perl versions to test against. |
This change skips the static/dynamic sections of the Makefile when using a
pure-Perl install so that no XS linking is done at all.
Compare the build logs below: