Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDI-19926] Put a file with FTP: An error doesn't occur when we change the local directory permissions. #9792

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

[PDI-19926] Fix MVSFileParser messages

aaea421
Select commit
Loading
Failed to load commit list.
Open

[PDI-19926] Put a file with FTP: An error doesn't occur when we change the local directory permissions. #9792

[PDI-19926] Fix MVSFileParser messages
aaea421
Select commit
Loading
Failed to load commit list.
HitachiVantaraSonarQube / Pentaho Data Integration Sonarqube Results failed Jan 17, 2025 in 2m 39s

Quality Gate failed

Failed

  • D Maintainability Rating on New Code (is worse than A)
  • 55.60% Coverage on New Code (is less than 80.00%)

Analysis Details

24 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 24 Code Smells

Coverage and Duplications

  • Coverage 55.60% Coverage (36.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (11.80% Estimated after merge)

Project ID: org.pentaho.di:pdi

View in SonarQube

Annotations

Check failure on line 147 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L147 

Define a constant instead of duplicating this literal "localDirectory" 5 times.

Check failure on line 160 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L160 

Define a constant instead of duplicating this literal "proxy_password" 4 times.

Check failure on line 145 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L145 

Define a constant instead of duplicating this literal "password" 5 times.

Check failure on line 163 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L163 

Define a constant instead of duplicating this literal "socksproxy_username" 4 times.

Check failure on line 157 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L157 

Define a constant instead of duplicating this literal "proxy_port" 4 times.

Check failure on line 154 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L154 

Define a constant instead of duplicating this literal "control_encoding" 4 times.

Check failure on line 153 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L153 

Define a constant instead of duplicating this literal "active" 4 times.

Check failure on line 149 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L149 

Define a constant instead of duplicating this literal "binary" 4 times.

Check failure on line 161 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L161 

Define a constant instead of duplicating this literal "socksproxy_host" 4 times.

Check failure on line 152 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L152 

Define a constant instead of duplicating this literal "only_new" 4 times.

Check failure on line 151 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L151 

Define a constant instead of duplicating this literal "remove" 4 times.

Check failure on line 150 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L150 

Define a constant instead of duplicating this literal "timeout" 4 times.

Check failure on line 148 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L148 

Define a constant instead of duplicating this literal "wildcard" 4 times.

Check failure on line 162 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L162 

Define a constant instead of duplicating this literal "socksproxy_port" 4 times.

Check failure on line 156 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L156 

Define a constant instead of duplicating this literal "proxy_host" 4 times.

Check failure on line 158 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L158 

Define a constant instead of duplicating this literal "proxy_username" 4 times.

Check failure on line 142 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L142 

Define a constant instead of duplicating this literal "serverport" 4 times.

Check failure on line 146 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L146 

Define a constant instead of duplicating this literal "remoteDirectory" 4 times.

Check failure on line 141 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L141 

Define a constant instead of duplicating this literal "servername" 4 times.

Check failure on line 165 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L165 

Define a constant instead of duplicating this literal "socksproxy_password" 4 times.

Check failure on line 143 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L143 

Define a constant instead of duplicating this literal "username" 4 times.

Check warning on line 210 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L210 

Add the "@Override" annotation above this method signature

Check failure on line 579 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L579 

Refactor this method to reduce its Cognitive Complexity from 66 to the 15 allowed.

Check failure on line 866 in plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java

See this annotation in the file changed.

@hitachivantarasonarqube hitachivantarasonarqube / Pentaho Data Integration Sonarqube Results

plugins/put-a-file-with-ftp/impl/src/main/java/org/pentaho/di/job/entries/ftpput/JobEntryFTPPUT.java#L866 

Refactor this method to reduce its Cognitive Complexity from 41 to the 15 allowed.
View more details on HitachiVantaraSonarQube