[BACKLOG-43170] Remove copyright headers from PAD, PRD, and PSW splas… #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h screens, as those lines now exist in the license text - Remove copyright label from SplashScreen and all related components that are not longer to be used
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: pentaho:pentaho-aggdesigner-parent-pom |
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 2m 20sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
pentaho-aggdesigner-ui👌 All tests passed! Tests run: 68, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
NJtwentyone
reviewed
Jan 17, 2025
| @@ -376,10 +376,6 @@ public void helpAboutLoad() { | |||
| XulLabel helpAboutVersionLabel = (XulLabel) document.getElementById("aboutVersion"); | |||
| helpAboutVersionLabel.setValue( Messages.getString( "about_version", version ) ); | |||
|
|
|||
| XulLabel helpAboutCopyrightLabel = (XulLabel) document.getElementById( "aboutCopyright" ); | |||
| helpAboutCopyrightLabel.setValue( Messages.getString( "about_copyright", "" | |||
NJtwentyone
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h screens, as those lines now exist in the license text