Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Page): Added secondary variant styling for Penta work #9848

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(Page): Added secondary variant styling for Penta work #9848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca61d02
feat(Page): Added secondary variant styling for Penta work
thatblindgeye Dec 4, 2023
da31555
Added new variant to examples to match core
thatblindgeye Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/react-core/src/components/Page/PageSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import { formatBreakpointMods } from '../../helpers/util';
import { PageContext } from './PageContext';

export enum PageSectionVariants {
default = 'default'
default = 'default',
secondary = 'secondary'
}

export enum PageSectionTypes {
Expand All @@ -22,8 +23,8 @@ export interface PageSectionProps extends React.HTMLProps<HTMLDivElement> {
children?: React.ReactNode;
/** Additional classes added to the section */
className?: string;
/** Section background color variant */
variant?: 'default';
/** Section background color variant. This will only apply when the type prop has the "default" value. */
variant?: 'default' | 'secondary';
/** Section type variant */
type?: 'default' | 'nav' | 'subnav' | 'breadcrumb' | 'tabs' | 'wizard';
/** Enables the page section to fill the available vertical space */
Expand Down Expand Up @@ -74,7 +75,8 @@ const variantType = {
};

const variantStyle = {
[PageSectionVariants.default]: ''
[PageSectionVariants.default]: '',
[PageSectionVariants.secondary]: styles.modifiers.secondary
};

export const PageSection: React.FunctionComponent<PageSectionProps> = ({
Expand Down Expand Up @@ -112,7 +114,7 @@ export const PageSection: React.FunctionComponent<PageSectionProps> = ({
variantType[type],
formatBreakpointMods(padding, styles),
formatBreakpointMods(stickyOnBreakpoint, styles, 'sticky-', getVerticalBreakpoint(height), true),
variantStyle[variant],
type === PageSectionTypes.default && variantStyle[variant],
isFilled === false && styles.modifiers.noFill,
isFilled === true && styles.modifiers.fill,
isWidthLimited && styles.modifiers.limitWidth,
Expand Down
1 change: 0 additions & 1 deletion packages/react-core/src/components/Page/examples/Page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ propComponents:
---

import BarsIcon from '@patternfly/react-icons/dist/js/icons/bars-icon';
import './page.css';
import c_page_section_m_limit_width_MaxWidth from '@patternfly/react-tokens/dist/esm/c_page_section_m_limit_width_MaxWidth';

## Examples
Expand Down
3 changes: 0 additions & 3 deletions packages/react-core/src/components/Page/examples/page.css
View file
Open in desktop

This file was deleted.

Loading