-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ChatbotConversationHistoryNav): Make it resizable #405
Conversation
Preview: https://chatbot-pr-chatbot-405.surge.sh A11y report: https://chatbot-pr-chatbot-405-a11y.surge.sh |
Allow consumers to pass PatternFly props down to subcomponents. Created demo for resizing as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resizing looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From more of a design perspective, I think it would be helpful to add a pf tooltip to the history items, to show the full string when there's truncation going on. Not sure the dev lift on that, though, so maybe it's a follow-up enhancement (if others agree with the idea)?
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
…mples/UI/UI.md Co-authored-by: Erin Donehoo <[email protected]>
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
…mples/UI/UI.md Co-authored-by: Erin Donehoo <[email protected]>
🎉 This PR is included in version 2.2.0-prerelease.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Allow consumers to pass PatternFly props down to subcomponents. Created demo for resizing as well: https://chatbot-pr-chatbot-405.surge.sh/patternfly-ai/chatbot/ui#resizable-drawer