Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ChatbotConversationHistoryNav): Make it resizable #405

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Jan 10, 2025

Allow consumers to pass PatternFly props down to subcomponents. Created demo for resizing as well: https://chatbot-pr-chatbot-405.surge.sh/patternfly-ai/chatbot/ui#resizable-drawer

@patternfly-build
Copy link

patternfly-build commented Jan 10, 2025

Allow consumers to pass PatternFly props down to subcomponents. Created demo for resizing as well.
@rebeccaalpert rebeccaalpert linked an issue Jan 10, 2025 that may be closed by this pull request
@rebeccaalpert rebeccaalpert changed the title Draft: feat(ChatbotConversationHistoryNav): Make it resizable feat(ChatbotConversationHistoryNav): Make it resizable Jan 10, 2025
Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resizing looks good!

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From more of a design perspective, I think it would be helpful to add a pf tooltip to the history items, to show the full string when there's truncation going on. Not sure the dev lift on that, though, so maybe it's a follow-up enhancement (if others agree with the idea)?

@nicolethoen nicolethoen merged commit 38e1d83 into patternfly:main Jan 15, 2025
5 checks passed
Copy link

🎉 This PR is included in version 2.2.0-prerelease.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make history drawer resizable
5 participants