-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(QuickStartsTile): Add quick starts tile for messages #377
Conversation
Preview: https://chatbot-pr-chatbot-377.surge.sh A11y report: https://chatbot-pr-chatbot-377-a11y.surge.sh |
45dc638
to
517a471
Compare
517a471
to
be9cb5c
Compare
Quick starts tile is based on the PF QuickStarts extension tile, with slightly reduced functionality (namely status tracking and shared context). The purpose of this card is simply to trigger a QuickStart in a different section of unrelated UI, so it accepts an onClick function and passes in its id when clicked.
be9cb5c
to
de7f6b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor edits ✍️
...odule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithQuickStart.tsx
Outdated
Show resolved
Hide resolved
...odule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithQuickStart.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Outdated
Show resolved
Hide resolved
…mples/Messages/MessageWithQuickStart.tsx Co-authored-by: Erin Donehoo <[email protected]>
…mples/Messages/MessageWithQuickStart.tsx Co-authored-by: Erin Donehoo <[email protected]>
…mples/Messages/Messages.md Co-authored-by: Erin Donehoo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! 👏
🎉 This PR is included in version 2.2.0-prerelease.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added quick starts tile, tests, and initial shot at docs section under the Messages section: https://chatbot-pr-chatbot-377.surge.sh/patternfly-ai/chatbot/messages#messages-with-quick-start-tiles
The tile mostly reuses code from the quick starts extension, with the context and status logic removed. I added props so strings can be internationalized if needed, but the API will be a little different than the main extension.
This is based on the parent extension tile: https://quickstarts.netlify.app. I stuck a max-width on it after talking to Kayla; have not made other design changes.