Partial fix for overflow-y scroll issue #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
commented
Jan 15, 2025
| @@ -24,6 +24,7 @@ along with this program. If not, see <https://www.gnu.org/licenses/>. | |||
| color: #000; | |||
| min-width: 1350px; | |||
| position: relative; | |||
| background: linear-gradient(0deg, rgba(0,0,0,0.2) 0%, rgb(255, 255, 255) 17%), white; | |||
There was a problem hiding this comment.
Just to keep the gradient that the box-shadow was providing (we remove the box shadow to avoid it cutting through the table when it's too big to fit)
niklasad1
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lots of table columns are visible, scrolling to the right looks very ugly and the table cells are hard/impossible to read (see #592).
With this tweak, we match the table backgorund colour when we scroll off, and remove a box shadow which would otherwise cut down along the table.
Before:
After:
This is far from the perfect fix (ideally the header would fill the space etc) but improves the situation at least.
An alternative is to just set
overflow-y: auto;on the relevant component, but the downside to this is that, when there are too many rows to fit on one page, you can no longer see the scroll bar that you need to use to scroll the table.