feat(light-client-ext-helpers): tx-helper #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b56ddd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanleecode
force-pushed
the
feat/lc-ext-helpers-tx-helper
branch
2 times, most recently
from
16a3b49 to
8e5365a
Compare
ryanleecode
force-pushed
the
feat/lc-ext-helpers-tx-helper
branch
from
8e5365a to
8bd76b3
Compare
marshacb
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tx-helper package to light client extension helpers.
This replaces the "copy and paste" tx-helper inside of wallet template. This new package uses the copy and pasted tx-helper but exposes a different public API. Namely one that does not have a dependnecy on
@polkadot-api/observable-client&@polkadot-api/substrate-clientbut simply@polkadot-api/json-rpc-provider. In addition, it assumes you always want to sign the transaction at the latest best block.This package makes integration for light client extensions easier since they only need to have a json rpc provider and a polkadot signer to sign a transaction.
Once this is merged, I will try using it in this PR to polkadot js extension and update the usage docs accordingly.