cargo-check: Run with both stable and MSRV Compilers #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgonzalezorlandoarm
commented
Nov 21, 2023
tgonzalezorlandoarm
commented
- Introduce a RUST_TOOLCHAIN_VERSION environment variable that gets used in ci.sh to decide on the compiler to use.
- Use this variable when running variable on nightly (coverage) or build checks on each pr.
- cargo check will now cover all feature cases with both MSRV and stable, which it was not doing. Fix the cargo check build with MSRV for certain options that were not being covered by fixing versions on the Cargo.lock file.
'rustup toolchain install' installs a toolchain but does not necessarily enforce the use of that toolchain. * Enforce the use of the installed toolchain via 'rustup default', which also installs it if needed. Signed-off-by: Tomás González <[email protected]>
* Run 'cargo check' only for the current Rust compiler. This can be used in a future commit to run two separate jobs with each compiler version, and test all feature combinations with each compiler. Signed-off-by: Tomás González <[email protected]>
Introduce a new RUST_TOOLCHAIN_VERSION environment variable for that can be used from inside the ci.sh script to override (only for the current directory) the current rust toolchain. Signed-off-by: Tomás González <[email protected]>
Currently, we are defining a variable in ci.sh to use the MSRV for coverage builds. * Install the MSRV Rust Toolchain from the ci job * Remove the MSRV variable from the ci.sh script This simplifies the logic and avoids potential errors. Signed-off-by: Tomás González <[email protected]>
The new rs-version input variable allows to run the ci.sh tests with a different rust version other than stable (the default value). Signed-off-by: Tomás González <[email protected]>
Currently, the build-all-provider job runs ci.sh cargo-check. * Run all cargo checks for both MSRV and Rust stable. Separate said job into two to support both compiler configurations. Signed-off-by: Tomás González <[email protected]>
Fix the version to one that is compatible with MSRV Signed-off-by: Tomás González <[email protected]>
gowthamsk-arm
approved these changes
Nov 22, 2023
minosgalanakis
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.