-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci.yml,deny.toml: Setup license testing #735
Merged
gowthamsk-arm
merged 5 commits into
parallaxsecond:main
from
tgonzalezorlandoarm:tg/cargo-deny
Nov 20, 2023
Merged
ci.yml,deny.toml: Setup license testing #735
gowthamsk-arm
merged 5 commits into
parallaxsecond:main
from
tgonzalezorlandoarm:tg/cargo-deny
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
force-pushed
the
tg/cargo-deny
branch
from
November 14, 2023 10:28
27462da
to
85d6937
Compare
tgonzalezorlandoarm
force-pushed
the
tg/cargo-deny
branch
from
November 15, 2023 12:12
85d6937
to
001be92
Compare
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
* Comment them out so as to be able to easily set them up when necessary, following the pattern seen by the default deny.toml. Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/cargo-deny
branch
from
November 20, 2023 15:51
001be92
to
f71df5a
Compare
minosgalanakis
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gowthamsk-arm
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a CI check for licenses. As we are pulling several crates from crates.io, we need to make sure that the licenses of those crates match the ones that we expect/accept.
We use cargo deny for that.
The deny.toml file has the configuration for accepted licenses, currently:
allow = [ "Apache-2.0", "Apache-2.0 WITH LLVM-exception", "BSD-3-Clause", "ISC", "LicenseRef-ring", "MIT", "Unicode-DFS-2016", ]
Signed-off-by: Tomás González [email protected]