-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and test dependencies' 'next' branch #732
Track and test dependencies' 'next' branch #732
Conversation
Please check the added test results in my fork: |
a34d6f6
to
f9093b3
Compare
I will generate, after this one gets merged, a follow up PR creating a |
https://github.com/tgonzalezorlandoarm/parsec/actions/runs/6786709261 new test on my fork after these changes |
b81ca7a
to
b643f67
Compare
7bc47d5
to
6185b22
Compare
6185b22
to
9a866fb
Compare
parsec depends on several repositories under the parallaxsecond organization. * Add a utils script to change the Cargo.toml and Cargo.lock files to start tracking the 'next' branches of those repositories. This script also builds the dependencies and parsec so that it can be used later on. Signed-off-by: Tomás González <[email protected]>
parsec depends on several repositories under the parallaxsecond organization. * Add a flag option (--test-next-branch-tracking) in ci.sh to track the 'test-next' branches of said repositories and test parsec with those updates. This test makes use of utils/release_tracking.py Signed-off-by: Tomás González <[email protected]>
ci.sh has been changed to support the --next-branch-tracking flag. This flag will not be used in the jobs defined in ci.yml but it will used in those jobs in a nightly frequency. * Set-up base job definitions that are going to be re-used in different workflows. * Use those re-usable actions in the ci.yml the same way that they were being used before. Signed-off-by: Tomás González <[email protected]>
parsec depends on several repositories under the parallaxsecond organization. Currently, when testing the main branch of parsec, fixed versions of the latest released crates of those repositories are being used. A problem may arise when there is a change introduced in the main/'test-next' branch of those repositories that would break parsec when updating/incorporating that change. This is currently not being tested in our CI. As parsec release is dependent on having published the dependencies' crates, there are issues that will not be caught until the publishing of said crates. * Add nightly jobs that use ci.sh --test-next-branch-tracking to test the next release branches of parallaxsecond repositories and spot issues before release. These jobs make use of previously defined re-usable actions. Signed-off-by: Tomás González <[email protected]>
* cargo update before building is key for avoiding an unused patch version, as the version in the Cargo.lock file will otherwise be preferred. * Improve python code quality. Signed-off-by: Tomás González <[email protected]>
9a866fb
to
e6f5983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
parsec depends on several repositories under the parallaxsecond organization.
Currently, when testing the main branch of parsec, fixed versions of the latest released crates of those repositories are being used.
A problem may arise when there is a change introduced in the main/'next' branch of those repositories that would break parsec when updating/incorporating that change. This is currently not being tested in our CI.
As parsec release is dependent on having published the dependencies' crates, there are issues that will not be caught until the publishing of said crates.
next release branches of parallaxsecond repositories and spot
issues before release. These jobs make use of previously defined
re-usable actions and utils/release_tracking.py