Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency cross matching #731

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,13 @@ jobs:
run: docker run -v $(pwd):/tmp/parsec -w /tmp/parsec --security-opt seccomp=unconfined ghcr.io/parallaxsecond/parsec-service-test-all /tmp/parsec/ci.sh coverage
- name: Collect coverage results
run: bash <(curl -s https://codecov.io/bash)

mismatcher:
name: Check for mismatched dependencies (those that have more than one version)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: "${{ github.event.inputs.rev }}"
- name: Run the container to execute the dependency mismatcher script
run: docker run -v $(pwd):/tmp/parsec -w /tmp/parsec ghcr.io/parallaxsecond/parsec-service-test-all /tmp/parsec/ci.sh mismatcher
13 changes: 13 additions & 0 deletions ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ while [ "$#" -gt 0 ]; do
coverage )
PROVIDER_NAME=$1
;;
mismatcher )
PROVIDER_NAME=$1
;;
*)
error_msg "Unknown argument: $1"
;;
Expand All @@ -210,6 +213,16 @@ fi

trap cleanup EXIT

if [ "$PROVIDER_NAME" = "mismatcher" ]; then
python3 $(pwd)/utils/dependency_cross_matcher.py --deps_dir $(pwd)
mismatcher_result=$?
if [ "$mismatcher_result" -ne 0 ]; then
error_msg "Found dependencies version mismatches"
fi

exit 0
fi

if [ "$PROVIDER_NAME" = "tpm" ] || [ "$PROVIDER_NAME" = "all" ] || [ "$PROVIDER_NAME" = "coverage" ]; then
# Copy the NVChip for previously stored state. This is needed for the key mappings test.
cp /tmp/ondisk/NVChip .
Expand Down
78 changes: 78 additions & 0 deletions utils/dependency_cross_matcher.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
import argparse
import re
import os
import subprocess
import sys


def run_cargo_tree(path):
cmd = 'cargo tree --all-features '
cmd += '--features tss-esapi/generate-bindings,cryptoki/generate-bindings -d'
prev_dir = os.getcwd()
os.chdir(os.path.join(path))
return subprocess.check_output(cmd.split(' ')).decode()


def run_deps_mismatcher(lines):
pat = re.compile('([a-zA-Z]\S+)\s(v\S+)')
deps = dict()
for line in lines.split('\n'):
m = pat.search(line)
if m is not None:
if m.group(1) in deps.keys():
if m.group(2) not in deps[m.group(1)]:
deps[m.group(1)].append(m.group(2))
else:
deps[m.group(1)] = [m.group(2)]
return deps


def get_deps_with_more_than_1v(deps_and_versions):
new_dict = dict()
for dep_name, versions in deps_and_versions.items():
if len(versions) > 1:
new_dict[dep_name] = versions
return new_dict


def print_deps(deps_and_versions):
for dep_name, versions in deps_and_versions.items():
print(f"{dep_name:<25} {versions}")


def main(argv=[], prog_name=''):
parser = argparse.ArgumentParser(prog='DependencyCrossmatcher',
description='Checks the version mismatches for dependencies '
'in Cargo based repositories')
parser.add_argument('--deps_dir',
required=True,
help='Existing directory that contains the Cargo.toml for analyzing'
'dependencies')
args = parser.parse_args()

mismatches = run_deps_mismatcher(run_cargo_tree(args.deps_dir))
print_deps(mismatches)

mismatches = get_deps_with_more_than_1v(mismatches)

print('---------------------mistmatches----------------------\n\n')
print_deps(mismatches)

exceptions = {
'base64': ['v0.13.1', 'v0.21.4'],
'bindgen': ['v0.57.0', 'v0.66.1'],
'bitflags': ['v1.3.2', 'v2.4.0'],
'cexpr': ['v0.4.0', 'v0.6.0'],
'nom': ['v5.1.3', 'v7.1.3'],
'shlex': ['v0.1.1', 'v1.2.0'],
'syn': ['v1.0.109', 'v2.0.38'],
}

if exceptions != mismatches:
return 1

return 0


if __name__ == '__main__':
sys.exit(main(sys.argv[1:], sys.argv[0]))
Loading