Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e_tests/mangled_ping: Fix socket path #728

Conversation

tgonzalezorlandoarm
Copy link
Member

@tgonzalezorlandoarm tgonzalezorlandoarm commented Oct 25, 2023

Use the environment variable PARSEC_SERVICE_ENDPOINT to define the socket path for the test.
This came up during HW testing (Trusted Service Provider). PARSEC_SERVICE_ENDPOINT may be defined to something different than /tmp/parsec.sock so we should be taking into account that case

@tgonzalezorlandoarm tgonzalezorlandoarm added the testing Task related to testing label Oct 25, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Oct 25, 2023
Use the environment variable PARSEC_SERVICE_ENDPOINT to define the
socket path for the test.

Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as ready for review October 26, 2023 11:39
@gowthamsk-arm
Copy link
Contributor

nit: In the commit description can you also add what prompted this change?

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit d890ce9 into parallaxsecond:main Oct 31, 2023
13 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/fix-mangled-ping-test branch November 23, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Task related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants