Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat field method #1173

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Flat field method #1173

merged 1 commit into from
Aug 20, 2022

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Aug 19, 2022

This method has been used off and on variously for a while. Ideally should be decoupled more from the hardware but getting it committed as is.

Replaces and closes #729.

Taken from #1167.

* This method has been used off and on variously for a while. Ideally should be decoupled more from the hardware but getting it committed as is.

Replaces and closes panoptes#729.
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1173 (88adae9) into develop (4908119) will decrease coverage by 8.24%.
The diff coverage is 60.53%.

@@             Coverage Diff             @@
##           develop    #1173      +/-   ##
===========================================
- Coverage    83.08%   74.83%   -8.25%     
===========================================
  Files           86       91       +5     
  Lines         7425     7809     +384     
  Branches       635      866     +231     
===========================================
- Hits          6169     5844     -325     
- Misses        1083     1824     +741     
+ Partials       173      141      -32     
Impacted Files Coverage Δ
src/panoptes/pocs/camera/gphoto/remote.py 0.00% <0.00%> (-21.57%) ⬇️
src/panoptes/pocs/sensor/power.py 40.23% <0.00%> (-1.74%) ⬇️
...rc/panoptes/pocs/state/states/default/analyzing.py 5.55% <0.00%> (-54.45%) ⬇️
src/panoptes/pocs/state/states/default/tracking.py 6.66% <0.00%> (-76.67%) ⬇️
src/panoptes/pocs/utils/cli/main.py 0.00% <0.00%> (-70.00%) ⬇️
src/panoptes/pocs/utils/database.py 0.00% <0.00%> (ø)
src/panoptes/pocs/utils/error.py 0.00% <0.00%> (ø)
src/panoptes/pocs/utils/logger.py 100.00% <ø> (ø)
tests/test_ioptron.py 66.66% <0.00%> (+0.70%) ⬆️
...rc/panoptes/pocs/state/states/default/observing.py 14.28% <16.66%> (-61.91%) ⬇️
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wtgee wtgee merged commit cd6092e into panoptes:develop Aug 20, 2022
@wtgee wtgee deleted the add-flat-fields branch August 20, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant