Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a SiteDetails dataclass when creating a location #1169

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Aug 19, 2022

Easier to work with SiteDetails. This will be a coming feature of some of the task-based work as well and assists with those coming changes.

Pulled from #1167

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1169 (d1a56c2) into develop (4908119) will decrease coverage by 8.70%.
The diff coverage is 56.49%.

@@             Coverage Diff             @@
##           develop    #1169      +/-   ##
===========================================
- Coverage    83.08%   74.37%   -8.71%     
===========================================
  Files           86       90       +4     
  Lines         7425     7708     +283     
  Branches       635      855     +220     
===========================================
- Hits          6169     5733     -436     
- Misses        1083     1835     +752     
+ Partials       173      140      -33     
Impacted Files Coverage Δ
src/panoptes/pocs/camera/gphoto/remote.py 0.00% <0.00%> (-21.57%) ⬇️
...rc/panoptes/pocs/scheduler/observation/compound.py 0.00% <0.00%> (ø)
src/panoptes/pocs/sensor/power.py 40.23% <0.00%> (-1.74%) ⬇️
...rc/panoptes/pocs/state/states/default/analyzing.py 5.55% <0.00%> (-54.45%) ⬇️
src/panoptes/pocs/state/states/default/tracking.py 6.66% <0.00%> (-76.67%) ⬇️
src/panoptes/pocs/utils/cli/main.py 0.00% <0.00%> (-70.00%) ⬇️
src/panoptes/pocs/utils/database.py 0.00% <0.00%> (ø)
src/panoptes/pocs/utils/error.py 0.00% <0.00%> (ø)
src/panoptes/pocs/utils/logger.py 100.00% <ø> (ø)
src/panoptes/pocs/utils/service/power.py 0.00% <0.00%> (-66.67%) ⬇️
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wtgee wtgee merged commit 612590f into panoptes:develop Aug 19, 2022
@wtgee wtgee deleted the location-dataclass branch August 19, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant