TST(string dtype): Resolve xfails in test_from_dummies #60694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.The current behavior assumes the
default_category
provided can be coerced to the dtype of the input's columns. When the input's columns labels are strings, and thedefault_category
is an integer, currently with object dtype we end up with values that are a mix of strings and integers. Withinfer_string=True
where the input's columns arestr
dtype, we end up instead with all strings (coercing the integer to a string).It's not clear to me whether this case should result in object dtype with a mix of strings and integers, or
str
dtype. Thoughts here are welcome. A few cases to consider are below. Currently I'm going with backwards compatibility, but open to other directions.