Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add authorized zkapps page #206

Merged
merged 4 commits into from
Aug 30, 2024
Merged

add authorized zkapps page #206

merged 4 commits into from
Aug 30, 2024

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Aug 27, 2024

Describe changes

Added a new page under settings to show Authorized Zk Apps

Ticket or discussion link

fix #192

Review checklist

  • Proper documentation added
  • Proper tests added

Screenshots

Screenshot 2024-08-27 at 01 56 36

Copy link

deepsource-io bot commented Aug 27, 2024

Here's the code health analysis summary for commits bc7ee21..c3e094a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 6 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Myestery Myestery marked this pull request as ready for review August 27, 2024 00:56
@Myestery
Copy link
Contributor Author

Hello @mrcnk
I have implemented the changes

@mrcnk
Copy link
Member

mrcnk commented Aug 30, 2024

@Myestery all's good, can you run pnpm format:unsafe and push the changes though?

@Myestery
Copy link
Contributor Author

Sure

@Myestery Myestery requested a review from mrcnk August 30, 2024 19:57
@mrcnk mrcnk merged commit 2753d11 into palladians:main Aug 30, 2024
2 checks passed
@Myestery
Copy link
Contributor Author

Hi @mrcnk
I'm a little confused as to what the next step is regarding claiming the bounty payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new route in Settings to display "Authorized zkApps"
2 participants