Portfolio value change calculation is broken when using Mina values

[aliraza556]

Problem:

• When using Mina values on Dashboard, the daily change +0.02 (24h) is broken, displaying pretty much the same value all the time.

closes: #198

Issue ticket number and link:

• Ticket Number: [ 198 ]
• Link: [ https://github.com/Portfolio value change calculation is broken when using Mina values #198 ]

Acceptance Criteria

• The value reflects an actual fiat change, but in Mina.

[aliraza556]

Hi @mrcnk, Please review this PR.

[deepsource-io]

Here's the code health analysis summary for commits ee3f2ee..dc6ed65. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[mrcnk]

Hey, just checked and:

• First there's an additional, unnecessary minus for negative values.
• Value is still fixed at -0.03, no matter of portfolio size.
  

[aliraza556]

Hey, just checked and:

• First there's an additional, unnecessary minus for negative values.
• Value is still fixed at -0.03, no matter of portfolio size.
  

@mrcnk Please review this PR: I have fixed

[mrcnk]

@aliraza556 It's now displaying fiat values both for fiat and Mina. For Mina it should display Mina value, so if for example the price of Mina is 50c, it should be:

Mina Change Value = Fiat Change Value / Fiat Price
In example: Fiat Change Value = 100 USD, Fiat Price = 50c
Mina Change Value = 100 USD / 0.5
Mina Change Value = 200 Mina

[aliraza556]

@aliraza556 It's now displaying fiat values both for fiat and Mina. For Mina it should display Mina value, so if for example the price of Mina is 50c, it should be:

Mina Change Value = Fiat Change Value / Fiat Price
In example: Fiat Change Value = 100 USD, Fiat Price = 50c
Mina Change Value = 100 USD / 0.5
Mina Change Value = 200 Mina

@mrcnk Please review it i have fixed

[mrcnk]

@aliraza556 it's working fine now, can you just format the code and push again?

[aliraza556]

@aliraza556 it's working fine now, can you just format the code and push again?

@mrcnk Ok

[aliraza556]

@mrcnk Done