Skip to content

Commit

Permalink
Fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
telip007 committed Apr 5, 2023
1 parent a18a808 commit 2366e00
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def upload(app_clip_default_experience, localizations, app_clip_header_images)
Helper.show_loading_indicator("Waiting for all the app clip header images to finish being processed...")
wait_for_complete(app_clip_default_experience.id)
Helper.hide_loading_indicator
# TODO: implement function similar to AppScreenshot's `retry_upload_screenshots_if_needed` for robustness

UI.message("Successfully uploaded all app clip header images")
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def upload_metadata(options)

UI.important("Will begin uploading app clip default experience metadata for '#{version.version_string}' on App Store Connect")

# TODO: support handling more than one app clip target per app
# Currently only one app clip target per app is supported
app_clips = app.get_app_clips
app_clip = app_clips.first

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ def self.create(client: nil, app_clip_default_experience_localization_id: nil, p
attributes: post_attributes
).first
rescue => error
# TODO: handle this error like how `app_screenshot` model does it
puts("ERROR: Unable to create app clip header image reservation, error: #{error}")
end

Expand Down

0 comments on commit 2366e00

Please sign in to comment.