refactor: switch proto files to SDK math #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/lockup
C:CLI
C:x/gamm
|
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
p0mvn
added
V:state/compatible/no_backport
p0mvn
requested review from
mattverse,
stackman27,
nicolaslara,
AlpinYukseloglu and
czarcas7ic
as code owners
mattverse
approved these changes
Sep 4, 2023
Comment on lines
+689
to
+690
| github.com/osmosis-labs/osmosis/osmomath v0.0.7-0.20230901175805-bab180bc078b h1:Sw0WZKfZrUz+ozJhcjZ64TQFOtOHwqSLKrNOLonhXUU= | ||
| github.com/osmosis-labs/osmosis/osmoutils v0.0.7-0.20230901175805-bab180bc078b h1:UFJcRrnM4q+kgvVvH35+Au5Mzj6Www4SYIF3LG0AvgM= |
There was a problem hiding this comment.
Just curious, why did these change?
There was a problem hiding this comment.
Because some protos in these packages were updated. We want to utilize the updated ones within the main module
|
Merging with one ACK since the risk is low and to avoid merge conflicts from waiting. If issues, will be fixed in future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6099
What is the purpose of the change
Updating proto files to references the new upstream math types
Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)