Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Functors to 0.5, (keep existing compat) #14

Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 5, 2024

This pull request changes the compat entry for the Functors package from 0.3, 0.4 to 0.3, 0.4, 0.5.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@oschulz oschulz force-pushed the compathelper/new_version/2024-11-05-00-26-38-824-03206560092 branch from 0c7144e to 879fbda Compare November 5, 2024 00:26
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.27%. Comparing base (7ba4292) to head (879fbda).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   68.84%   70.27%   +1.42%     
==========================================
  Files           4        3       -1     
  Lines         260      259       -1     
==========================================
+ Hits          179      182       +3     
+ Misses         81       77       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jebej
Copy link

jebej commented Jan 15, 2025

Can this be merged @oschulz? PropDicts is now holding back packages which depend on Functors 0.5

@oschulz
Copy link
Owner

oschulz commented Jan 16, 2025

Sorry, lost track of this @jebej . I'll need to do some manual things for this, due to the changes in Functors 0.5, but I can get on it today.

@jebej
Copy link

jebej commented Jan 16, 2025

No worries, I hadn't realized this required manual changes.

@oschulz
Copy link
Owner

oschulz commented Jan 16, 2025

No worries, I hadn't realized this required manual changes.

To do it a bit cleanly yes, because Functors 0.5 can autogenerate more functors. Give me another day or two, lot's going on. :-)

@oschulz
Copy link
Owner

oschulz commented Jan 20, 2025

To do it a bit cleanly yes, because Functors 0.5 can autogenerate more functors.

Turns out it can actually not autogenerate the custom functor we need, so we'll use this after all. :-)

@oschulz oschulz merged commit 23cfd11 into main Jan 20, 2025
11 checks passed
@oschulz oschulz deleted the compathelper/new_version/2024-11-05-00-26-38-824-03206560092 branch January 20, 2025 16:12
@oschulz
Copy link
Owner

oschulz commented Jan 20, 2025

JuliaRegistries/General#123352

Sorry for the delay @jebej !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants