Move to using embedded Vue app for QR Code page #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
…sage Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
amanji
reviewed
Apr 1, 2024
esune
requested changes
Apr 1, 2024
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
amanji
reviewed
Apr 1, 2024
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
amanji
previously approved these changes
Apr 2, 2024
loneil
requested changes
Apr 2, 2024
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Just tested this. Should work now |
loneil
approved these changes
Apr 2, 2024
esune
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves #432
In addition to the migration to Vue this PR adds a timer to catch when a credential has been stuck in the pending state for over a minute prompting the user.
As well as providing this feedback users are also informed on possible reasons for a failed credential.
I am not 100% sure these error messages make sense in all cases so feedback on them is appreciated.