Updated ngrok configuration #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Suñé <[email protected]>
…e single ngrok container Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Jsyro
approved these changes
Jan 29, 2024
Unit tests or manual configuration are still supported, however it was just too complicated to maintain and most use-cases will likely run a read-only agent. That being said, vc-authn can still be ocnfigured to use a Traction tenant, and I believe unit-tests cover that bit too (will check and log issues if necessary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #402
This PR updates the ngrok configuration to use a single container and therefore requiring only one authtoken to be provided.
To do so, a lot of the complexity in the
managescript was removed, in particular options to run in multi-tenant mode have been removed since they made the script very complicated to maintain. It is still possible to run the service using a Traction agent, but this is not supported in the demo now.Lastly, a tweak to the stale PR criteria was added to NOT mark as stale PRs that deal with dependency updates.