Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chainspec irregularities #493

Merged
merged 31 commits into from
Jul 2, 2024
Merged

fix: chainspec irregularities #493

merged 31 commits into from
Jul 2, 2024

Conversation

orriin
Copy link
Contributor

@orriin orriin commented May 30, 2024

Closes #489

  • Sets SS58 format in Rust chain spec definitions to match chain spec JSON
  • Sets missing protocol_id in Rust chain spec definitions
  • Rebuilds plain_spec_finney.json, plain_spec_testfinney.json, raw_spec_finney.json, raw_spec_testfinney.json
  • Removes finney_plain_spec.json, raw_spec.json, raw_testspec.json since they appeared stale and I do not understand their purpose
  • Adds CI that builds and commits updated chain specs on push to branches development, staging, main

TODO

  • Check if we need bootnodes
  • Create script to easily update chainspecs
  • Add CI to enforce JSON chain spec stays consistent with the Rust definitions

@orriin orriin added the blue team defensive programming, CI, etc label May 30, 2024
@orriin orriin marked this pull request as draft May 30, 2024 09:28
@prop-opentensor
Copy link

prop-opentensor commented May 31, 2024

bootnodes:

finney: /dns/bootnode.finney.chain.opentensor.ai/tcp/30333/ws/p2p/12D3KooWRwbMb85RWnT8DSXSYMWQtuDwh4LJzndoRrTDotTR5gDC
testnet:
/dns/bootnode.test.chain.opentensor.ai/tcp/30333/p2p/12D3KooWPM4mLcKJGtyVtkggqdG84zWrd7Rij6PGQDoijh1X86Vr

fyi: raw_testspec.json is currently in use on devnet validators - since we plan to replace devnet with the testnet mirror, imo this can still be removed

@orriin
Copy link
Contributor Author

orriin commented May 31, 2024

fyi: raw_testspec.json is currently in use on devnet validators - since we plan to replace devnet with the testnet mirror, imo this can still be removed

Cool, yeah I'm removing all of finney_plain_spec.json, raw_spec.json, raw_testspec.json, they seem to just be duplicates.

@birkskyum
Copy link

birkskyum commented May 31, 2024

related - i just noticed that the mainnet spec files was also used for people wanting to start at testnet docker container, but it might be obsoleted if those spec files are now deleted

Also, these raw_spec.json is mentioned in docs all over the place, which would be good to have synced with this change

@orriin orriin force-pushed the fix/chainspecs branch 2 times, most recently from 16fff59 to 1fdeb7f Compare May 31, 2024 16:24
@birkskyum
Copy link

out of curiosity, what is the difference between raw_spec and plain_spec?

@orriin orriin force-pushed the fix/chainspecs branch 4 times, most recently from 41ffbe6 to e853225 Compare June 2, 2024 06:58
@orriin
Copy link
Contributor Author

orriin commented Jun 2, 2024

out of curiosity, what is the difference between raw_spec and plain_spec?

See the 'Raw chain specifications' section at these docs https://docs.substrate.io/build/chain-spec/

@orriin orriin force-pushed the fix/chainspecs branch 2 times, most recently from 3557edc to 641fed9 Compare June 2, 2024 07:09
@sam0x17 sam0x17 requested a review from a team June 19, 2024 18:34
@sam0x17 sam0x17 added devnet-ready PR's companion has been merged into devnet-ready blue team defensive programming, CI, etc and removed blue team defensive programming, CI, etc labels Jun 21, 2024
@orriin orriin added devnet-pass PR has been tested on devnet on-devnet PR has been deployed to devnet and removed devnet-pass PR has been tested on devnet labels Jun 25, 2024
@sam0x17 sam0x17 removed the devnet-ready PR's companion has been merged into devnet-ready label Jun 25, 2024
@rajkaramchedu
Copy link
Contributor

We don't use the word "finney" in the published docs. We use "mainnet" or "testnet" or "devnet" or "local". Given this, for clarifying what's what in my docs, are the below two statements accurate?

  • The raw_spec_finney.json spec is for mainnet.
  • The raw_spec_testfinney.json spec is for testnet.

Thanks

@orriin
Copy link
Contributor Author

orriin commented Jun 26, 2024

We don't use the word "finney" in the published docs. We use "mainnet" or "testnet" or "devnet" or "local". Given this, for clarifying what's what in my docs, are the below two statements accurate?

  • The raw_spec_finney.json spec is for mainnet.
  • The raw_spec_testfinney.json spec is for testnet.

Thanks

This is correct :)

@orriin orriin added the on-testnet PR has been deployed to testnet label Jul 2, 2024
@orriin orriin added the testnet-pass PR was successfully tested on testnet label Jul 2, 2024
@orriin orriin merged commit ce6793d into main Jul 2, 2024
17 of 20 checks passed
@orriin orriin deleted the fix/chainspecs branch July 2, 2024 17:34
@sam0x17 sam0x17 mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blue team defensive programming, CI, etc devnet-pass PR has been tested on devnet on-devnet PR has been deployed to devnet on-testnet PR has been deployed to testnet testnet-pass PR was successfully tested on testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chainspec consistency
7 participants