Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/evm rao staking #1153

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Feat/evm rao staking #1153

merged 6 commits into from
Jan 14, 2025

Conversation

gztensor
Copy link
Contributor

Description

Implement usage of netuid parameter in staking precompile in add_stake and remove_stake.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

none

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor changed the base branch from main to devnet-ready January 14, 2025 15:14
@gztensor gztensor marked this pull request as ready for review January 14, 2025 15:14
@gztensor gztensor requested a review from unconst as a code owner January 14, 2025 15:14
ales-otf
ales-otf previously approved these changes Jan 14, 2025
runtime/src/precompiles/staking.rs Outdated Show resolved Hide resolved
sam0x17
sam0x17 previously approved these changes Jan 14, 2025
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 14, 2025
@gztensor gztensor dismissed stale reviews from sam0x17 and ales-otf via 75a281e January 14, 2025 15:58
ales-otf
ales-otf previously approved these changes Jan 14, 2025
@gztensor gztensor added no-spec-version-bump PR does not contain changes that requires bumping the spec version and removed no-spec-version-bump PR does not contain changes that requires bumping the spec version labels Jan 14, 2025
@sam0x17 sam0x17 merged commit bffc8b6 into devnet-ready Jan 14, 2025
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAO] Update staking precompile to handle staking to subnets
3 participants