Use turbo for the settings page to stop the URL changing #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nertc
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Code works properly and solves the issue raised in the comment mentioned in the description.
There is also a different idea to solve the problem (#5449 (comment)), but this PR has other benefits too, like moving errors from email to new_email properly and optimizing count.zero case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the user settings page to use turbo to fix the problem identified in #5449 (comment) where the URL changes when submitting a settings page with errors.
It also fixes an issue where errors weren't moved from the
emailto thenew_emailattribute properly, and simplifies checking if errors are present.