-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347924: Replace SIZE_FORMAT in memory and metaspace #23157
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please review this change to replace SIZE_FORMAT with %zu in the memory and metaspace directories. This code prints a lot of numbers so splitting this out. Most done by script but a couple of hand-edited commits.
Testing with tier1-4.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23157/head:pull/23157
$ git checkout pull/23157
Update a local copy of the PR:
$ git checkout pull/23157
$ git pull https://git.openjdk.org/jdk.git pull/23157/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23157
View PR using the GUI difftool:
$ git pr show -t 23157
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23157.diff
Using Webrev
Link to Webrev Comment