Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347923: Parallel: Simplify compute_survivor_space_size_and_threshold #23155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 16, 2025

Trivial extracting out the common subexpression from both if-else branches.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347923: Parallel: Simplify compute_survivor_space_size_and_threshold (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23155/head:pull/23155
$ git checkout pull/23155

Update a local copy of the PR:
$ git checkout pull/23155
$ git pull https://git.openjdk.org/jdk.git pull/23155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23155

View PR using the GUI difftool:
$ git pr show -t 23155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23155.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347923: Parallel: Simplify compute_survivor_space_size_and_threshold

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • e7795cc: 8347347: Build fails undefined symbol: __asan_init by clang17
  • 788f049: 8346607: IGV: Support drag-and-drop for opening graph files
  • bfa0cb7: 8347730: Replace SIZE_FORMAT in g1
  • 3b6e576: 8347825: Make IDEA ide support use proper build system mechanisms
  • 8bfa540: 8347731: Replace SIZE_FORMAT in zgc
  • cbe2f96: 8347732: Replace SIZE_FORMAT in shenandoah
  • f64f22b: 8346107: Generators: testing utility for random value generation
  • 4ad5d55: 8325030: PhaseMacroExpand::value_from_mem_phi assert with "unknown node on this path"
  • 24de9de: 8347370: Unnecessary Hashtable usage in javax.swing.text.html.HTML

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8347923 8347923: Parallel: Simplify compute_survivor_space_size_and_threshold Jan 16, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 16, 2025

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants