Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345049: Remove the jmx.tabular.data.hash.map compatibility property #23153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jan 16, 2025

Remove the System Property "jmx.tabular.data.hash.map" which was introduced historically for JMX compatibility with JDK 1.3 clients.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8347920 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8345049: Remove the jmx.tabular.data.hash.map compatibility property (Enhancement - P4)
  • JDK-8347920: Remove the jmx.tabular.data.hash.map compatibility property (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23153/head:pull/23153
$ git checkout pull/23153

Update a local copy of the PR:
$ git checkout pull/23153
$ git pull https://git.openjdk.org/jdk.git pull/23153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23153

View PR using the GUI difftool:
$ git pr show -t 23153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23153.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls kevinjwalls marked this pull request as ready for review January 16, 2025 13:06
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Pull request needs approved CSR before integration jmx [email protected] rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant