Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Math.min #23138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aviad1486
Copy link

@aviad1486 aviad1486 commented Jan 15, 2025

This change extends the Math.min function to support multiple parameters, improving its usability and code readability.

Previously, finding the minimum value among multiple variables required using nested Math.min calls or converting the variables into an array and iterating through it. This enhancement provides a more intuitive and straightforward approach to achieve the same result.

Benefits:

Simplifies code by eliminating the need for nested Math.min calls.
Enhances readability, especially when comparing multiple values.
Offers consistency with existing Math.min usage patterns.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23138/head:pull/23138
$ git checkout pull/23138

Update a local copy of the PR:
$ git checkout pull/23138
$ git pull https://git.openjdk.org/jdk.git pull/23138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23138

View PR using the GUI difftool:
$ git pr show -t 23138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23138.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 15, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2025

Hi @aviad1486, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user aviad1486" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@aviad1486 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant