8344969: Remove the jmx.mxbean.multiname compatibility property #23131
Conversation
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@kevinjwalls The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| @@ -41,8 +40,7 @@ | |||
| public class SameObjectTwoNamesTest { | |||
|
|
|||
| public static void main(String[] args) throws Exception { | |||
| boolean expectException = | |||
| (System.getProperty("jmx.mxbean.multiname") == null); | |||
| boolean expectException = true; | |||
There was a problem hiding this comment.
I think it would be better to drop this variable at all (and remove unreachable code when the variable is "false")
There was a problem hiding this comment.
Yes sure, can remove that and simplify this small test - done.
Remove the System Property "jmx.mxbean.multiname" which was introduced in JDK-7 for compatibility with code which may have depended on previous incorrect behaviour. Removal is long overdue.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23131/head:pull/23131$ git checkout pull/23131Update a local copy of the PR:
$ git checkout pull/23131$ git pull https://git.openjdk.org/jdk.git pull/23131/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23131View PR using the GUI difftool:
$ git pr show -t 23131Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23131.diff
Using Webrev
Link to Webrev Comment