Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347794: RISC-V: Add Zfhmin - Float cleanup #23130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Jan 15, 2025

Hey, please consider.

I'm looking making RVA23 support complete and I was looking into adding Zfhmin.
I notice Zfh instructions didn't have any asserts checking if this extensions was enabled.
I then notice that we had the inferior instruction description using a funct7 instead of FMT + funct5.
We also had this same format repeated many times.

This patch takes all instructions format duplicates and replaces them with 'fp_base'.
fadd_s is thus described in code as:
fp_base<S_32_sp, 0b00000>(Rd, Rs1, Rs2, rm);
Instead of:
INSN(fadd_s, 0b1010011, 0b0000000);

It then moves zfh/zfhmin to a sepererate section and assert checks them.

Also as a bonus RoundingMode uses camel case while fclass_mask C, style.
So I changed fclass_mask to FClassBit, now thinking about it not sure if it should be bit or mask.
As in the context of the instruction fclass it is a bit, but when using the helpers e.g. zero it's a mask.

Tested:
jdk/java/lang/Math
jdk/java/util/Formatter/
jdk/java/lang/Float/
jdk/java/lang/Double/
hotspot/jtreg/compiler/floatingpoint/
hotspot/jtreg/compiler/c2/FloatingPointFoldingTest.java
hotspot/jtreg/compiler/eliminateAutobox/
hotspot/jtreg/vmTestbase/jit/

And tier1 twice, no FP issues. (Using UseZfh/min)

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347794: RISC-V: Add Zfhmin - Float cleanup (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23130/head:pull/23130
$ git checkout pull/23130

Update a local copy of the PR:
$ git checkout pull/23130
$ git pull https://git.openjdk.org/jdk.git pull/23130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23130

View PR using the GUI difftool:
$ git pr show -t 23130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23130.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 15, 2025
@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 15, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant