Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet invocation section to mention Digital Credentials API #359

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

jogu
Copy link
Collaborator

@jogu jogu commented Dec 2, 2024

Also remove the 'no specific authorization endpoint' method that was never clearly specified and no one seems to be using.

closes #87
closes #262

Also remove the 'no specific authorization endpoint' method that was never
clearly specified and no one seems to be using.

closes #87
closes #262

For a cross device flow, either of the URL options MAY be presented as a QR code for the End-User to scan using a wallet or an arbitrary camera application on a user-device.

The Wallet can also be invoked from the web or a native app using the Digital Credentials API as described in (#dc_api).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this one first and if possible word it so it sounds like the preferred option :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might get some pushback against essentially recommending it so I'd rather consider that separately. Opened #361 for that.

I think we can be clearer about the advantages though - @leecam @timcappalli could you check the new text please? Suggestions to improve it are welcome!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a whole paragraph on the benefits that Tim helped re-write here: https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#appendix-A-4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've committed Kristina's suggestion to just refer to the existing text now.

Co-authored-by: Oliver Terbu <[email protected]>
@Sakurann Sakurann requested review from awoie and leecam December 3, 2024 08:32
openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved
Co-authored-by: Christian Bormann <[email protected]>

For a cross device flow, either of the above options MAY be presented as a QR code for the End-User to scan using a wallet or an arbitrary camera application on a user-device.

The Wallet can also be invoked from the web or a native app using the Digital Credentials API as described in (#dc_api). As described in detail in (#dc_api), DC API provides privacy, security (see (#session_fixation)), and user experience benefits (particularly in the cases where a user has multiple Wallets).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer putting DC API into the enumeration but that's just nitpicking

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do that when DC API is ready for production and we are changing this text to recommend it.

@Sakurann Sakurann merged commit 2c69c02 into main Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants