Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated DateTimeType methods toLocaleZone and toZone #4522

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Remove deprecated DateTimeType methods toLocaleZone and toZone #4522

merged 1 commit into from
Dec 31, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 27, 2024

@jlaur jlaur requested a review from a team as a code owner December 27, 2024 00:13
holgerfriedrich
holgerfriedrich approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Methods are deprecated for more than one year.
Thanks for giving the context about getZonedDateTime().

@holgerfriedrich holgerfriedrich merged commit 139a2e2 into openhab:main Dec 31, 2024
3 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.0 milestone Dec 31, 2024
@holgerfriedrich holgerfriedrich added the enhancement An enhancement or new feature of the Core label Dec 31, 2024
@jlaur
Copy link
Contributor Author

jlaur commented Dec 31, 2024

LGTM. Methods are deprecated for more than one year.

Actually they were recently deprecated in 4.3. But they make absolutely no sense anymore.

@jlaur jlaur deleted the datetimetype-remove-deprecated-methods branch December 31, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaur @holgerfriedrich