Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear warnings in org.openhab.core.id #4498

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Clear warnings in org.openhab.core.id #4498

merged 1 commit into from
Jan 14, 2025

Conversation

clinique
Copy link
Contributor

From 3 to 0. Added null annotations.

@clinique clinique requested a review from a team as a code owner December 16, 2024 15:44
holgerfriedrich
holgerfriedrich approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich merged commit 15eb5cc into openhab:main Jan 14, 2025
3 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.0 milestone Jan 14, 2025
@jlaur
Copy link
Contributor

jlaur commented Jan 15, 2025 •
edited
Loading

This broke the addons build, see:
https://github.com/openhab/openhab-addons/actions/runs/12787425960/job/35646575880

Code line having the issue:
https://github.com/openhab/openhab-addons/blob/7870b15fc304006917ff2980988d3165b37d8ed3/bundles/org.openhab.binding.nuki/src/main/java/org/openhab/binding/nuki/internal/NukiHandlerFactory.java#L82

@kaikreuzer kaikreuzer mentioned this pull request Jan 15, 2025
Merged
@jlaur
Copy link
Contributor

jlaur commented Jan 15, 2025

Sorry for being short, was in a rush, so just wanted to share. @kaikreuzer already provided a fix in openhab/openhab-addons#18109.

@holgerfriedrich
Copy link
Member

@jlaur don't mind. Thanks for the notification.

And sorry for breaking the build. I did not check the next CI build after merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clinique @jlaur @holgerfriedrich