Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mercedesme] Add missing status parameter for web socket error #18115

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[mercedesme] Add missing status parameter for web socket error #18115

merged 1 commit into from
Jan 16, 2025

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Jan 16, 2025

WebSocket error status detail message is declared with a parameter providing the reason. This reason isn't forwarded by the code.
This bugfix corrects it.

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 16, 2025
jlaur
jlaur approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jlaur
Copy link
Contributor

jlaur commented Jan 16, 2025

For reference:

openhab-addons/bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/i18n/mercedesme.properties

Line 386 in dfeac54

mercedesme.account.status.websocket-failure = Websocket Exception: Reason: {0}

@jlaur jlaur merged commit 34f81c6 into openhab:main Jan 16, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Jan 16, 2025
jlaur pushed a commit that referenced this pull request Jan 16, 2025
@weymann @jlaur
add missing parameter for status message (#18115)
f89303d 
Signed-off-by: Bernd Weymann <[email protected]>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@weymann @jlaur