-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lifx] Fix QuantityType Color Temperature command #17943
Conversation
Signed-off-by: Andrew Fiddian-Green <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Don't think we need to backport this one. Do you agree @andrewfg ? |
@lolodomo indeed no need to backport; it just fixes a compiler warning. |
@lolodomo - consider removing the "enhancement" label, since there is probably no reason to even mention this tiny technical refactoring in the release notes? Users will wonder what is "fixed". |
I agree. Done. |
Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Split from #17919
Signed-off-by: Andrew Fiddian-Green [email protected]