Fix open issues

Signed-off-by: Mark Hilbush <[email protected]>
openhab · Jan 16, 2025 · 097696a · 097696a
1 parent baaaf7f
commit 097696a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/...ee/src/main/java/org/openhab/binding/ecobee/internal/function/CreateVacationFunction.java b/...ee/src/main/java/org/openhab/binding/ecobee/internal/function/CreateVacationFunction.java
@@ -51,8 +51,8 @@ public CreateVacationFunction(@Nullable String name, @Nullable QuantityType<Temp
         if (convertedCoolHoldTemp == null || convertedHeatHoldTemp == null) {
             throw new IllegalArgumentException("coolHoldTemp or heatHoldTemp are not proper QuantityTypes");
         }
-        params.put("coolHoldTemp", Integer.valueOf(convertedCoolHoldTemp.intValue()));
-        params.put("heatHoldTemp", Integer.valueOf(convertedHeatHoldTemp.intValue()));
+        params.put("coolHoldTemp", Integer.valueOf(convertedCoolHoldTemp.intValue() * 10));
+        params.put("heatHoldTemp", Integer.valueOf(convertedHeatHoldTemp.intValue() * 10));
 
         if (startDateTime != null) {
             params.put("startDate", YMD.format(startDateTime));

diff --git a/.../main/java/org/openhab/binding/ecobee/internal/handler/EcobeeThermostatBridgeHandler.java b/.../main/java/org/openhab/binding/ecobee/internal/handler/EcobeeThermostatBridgeHandler.java
@@ -87,6 +87,8 @@ public class EcobeeThermostatBridgeHandler extends BaseBridgeHandler {
 
     private final Logger logger = LoggerFactory.getLogger(EcobeeThermostatBridgeHandler.class);
 
+    private static final int MIN_VALID_ACTUAL_TEMPERATURE = 0;
+
     private TimeZoneProvider timeZoneProvider;
     private ChannelTypeRegistry channelTypeRegistry;
 
@@ -396,7 +398,12 @@ private void updateRuntime(@Nullable RuntimeDTO runtime) {
                 EcobeeUtils.undefOrDate(runtime.lastStatusModified, timeZoneProvider));
         updateChannel(grp + CH_RUNTIME_DATE, EcobeeUtils.undefOrString(runtime.runtimeDate));
         updateChannel(grp + CH_RUNTIME_INTERVAL, EcobeeUtils.undefOrDecimal(runtime.runtimeInterval));
-        updateChannel(grp + CH_ACTUAL_TEMPERATURE, EcobeeUtils.undefOrTemperature(runtime.actualTemperature));
+        if (runtime.actualTemperature > MIN_VALID_ACTUAL_TEMPERATURE) {
+            updateChannel(grp + CH_ACTUAL_TEMPERATURE, EcobeeUtils.undefOrTemperature(runtime.actualTemperature));
+        } else {
+            logger.debug("Skipping update of actual temperature because temperature {} below min threshold of {}",
+                    runtime.actualTemperature, MIN_VALID_ACTUAL_TEMPERATURE);
+        }
         updateChannel(grp + CH_ACTUAL_HUMIDITY, EcobeeUtils.undefOrQuantity(runtime.actualHumidity, Units.PERCENT));
         updateChannel(grp + CH_RAW_TEMPERATURE, EcobeeUtils.undefOrTemperature(runtime.rawTemperature));
         updateChannel(grp + CH_SHOW_ICON_MODE, EcobeeUtils.undefOrDecimal(runtime.showIconMode));