Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DataQuery definitions #475

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Refactor DataQuery definitions #475

merged 9 commits into from
Nov 23, 2023

Conversation

m-burgoyne
Copy link
Collaborator

Modify the EDR Query OpenAPI schemas to inherit common properties

chris-little
chris-little approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected one snippet of grammar, rest OK

@chris-little
Copy link
Contributor

Agreed at EDR API SWG 2023-11-23 that change is editorial refactoring of schema. Nothing new.

@chris-little chris-little merged commit baada5d into master Nov 23, 2023
1 check passed
@chris-little chris-little deleted the Refactor-DataQuery-definitions branch November 23, 2023 15:12
@chris-little chris-little mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-little chris-little chris-little approved these changes

@tomkralidis tomkralidis Awaiting requested review from tomkralidis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-burgoyne @chris-little