Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nutrition facts KP: toggle per 100g/serving #6234

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 18, 2025

Hi everyone!

The toggle between per 100g/per serving was not working in the KP.
https://github.com/user-attachments/assets/f6166077-4cb3-4678-9b0c-ec7d45024533

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 6.20%. Comparing base (4d9c7fc) to head (553513a).
Report is 674 commits behind head on develop.

Files with missing lines Patch % Lines
...l/knowledge_panels/knowledge_panel_table_card.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6234      +/-   ##
==========================================
- Coverage     9.54%   6.20%   -3.35%     
==========================================
  Files          325     456     +131     
  Lines        16411   26707   +10296     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   25051   +10207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit a9f9c47 into openfoodfacts:develop Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants