Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snackbar action button with a different background color #6233

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 18, 2025

Hi everyone!

To improve the readability/accessibility of SnackBar buttons, they now have a background color.
Also, we've received one feedback on Slack: the duration of the SnackBar used on the lists is too short (fixed).

Before/After:
Untitled

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 6.20%. Comparing base (4d9c7fc) to head (f8162fd).
Report is 674 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/generic_lib/widgets/smooth_snackbar.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6233      +/-   ##
==========================================
- Coverage     9.54%   6.20%   -3.35%     
==========================================
  Files          325     456     +131     
  Lines        16411   26715   +10304     
==========================================
+ Hits          1567    1657      +90     
- Misses       14844   25058   +10214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants