Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nutrition page (auto-focus on new fields + owner field) #6218

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 16, 2025

Hi everyone!

This PR changes 2 behaviors on the nutrition page:

  • When a new field is added (eg: calcium), the focus will be moved to the text field
  • For the owner field icon, it opens the modal sheet with explanations

Video:

ScreenRecording_01-16-2025.02-54-20_1.MP4

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 6.20%. Comparing base (4d9c7fc) to head (db03640).
Report is 670 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% 21 Missing ⚠️
...b/pages/product/nutrition_add_nutrient_button.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6218      +/-   ##
==========================================
- Coverage     9.54%   6.20%   -3.35%     
==========================================
  Files          325     456     +131     
  Lines        16411   26692   +10281     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   25036   +10192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
Please have a look at my comments.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g123k for your changes!
Still not convinced by your unexpected dispose calls, but as I currently have limited ways of reviewing and as you've confirmed it's ok, that's good enough for me!

@teolemon teolemon merged commit db1d0b8 into openfoodfacts:develop Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants