Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Eco-Score -> Green Score #6072

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 27, 2024

Hi everyone!

The Eco-Score is renamed to Green-Score.
All assets are changed + symbols in the app.

@github-actions github-actions bot added 🥫 Product page 📈 Analytics We use Sentry and Matomo, with an opt-in system 🌐 l10n 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. asset cache cached assets (SVG…) for the knowledge panels Assets cache labels Dec 27, 2024
@g123k g123k linked an issue Dec 27, 2024 that may be closed by this pull request
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make whenever possible and sensible the wording into EnvironnementalScore @g123k ?
We can keep GreenScore for assets and user visible strings, but for long lasting files, I'd be in favor of something more generic.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 6.44%. Comparing base (4d9c7fc) to head (1475689).
Report is 581 commits behind head on develop.

Files with missing lines Patch % Lines
.../product/add_new_product/add_new_product_page.dart 0.00% 15 Missing ⚠️
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% 8 Missing ⚠️
...app/lib/pages/product/product_incomplete_card.dart 0.00% 2 Missing ⚠️
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% 1 Missing ⚠️
...pp/lib/pages/preferences/user_preferences_faq.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6072      +/-   ##
==========================================
- Coverage     9.54%   6.44%   -3.11%     
==========================================
  Files          325     444     +119     
  Lines        16411   25211    +8800     
==========================================
+ Hits          1567    1625      +58     
- Misses       14844   23586    +8742     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g123k 👍

@teolemon
Copy link
Member

Thanks for the rebase @g123k 👍

@teolemon teolemon merged commit baea968 into openfoodfacts:develop Dec 27, 2024
6 checks passed
@g123k g123k deleted the greenscore branch December 30, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system asset cache cached assets (SVG…) for the knowledge panels Assets cache 🌐 l10n 🥫 Product page 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Eco-Score -> Green Score
3 participants