fix: accented values for facets #9483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Swell @stephanegigandet 👏👏👏 |
teolemon
approved these changes
Dec 5, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9483 +/- ##
==========================================
- Coverage 49.03% 49.02% -0.01%
==========================================
Files 66 66
Lines 20422 20434 +12
Branches 4901 4905 +4
==========================================
+ Hits 10013 10018 +5
- Misses 9142 9147 +5
- Partials 1267 1269 +2 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
✏️ Editing - Auto Suggest
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
reviewed
Dec 7, 2023
| } | ||
|
|
||
| return @params; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unlimited facets feature broke accented facets in languages that we don't de-accent (e.g. German).
Added some tests.
This should fix #9437 and #9465