fix: og-url for donate page to get correct Facebook share preview, change meta title #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
GitHub Actions
teolemon
approved these changes
Nov 22, 2023
teolemon
reviewed
Nov 22, 2023
Co-authored-by: Pierre Slamich <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9356 +/- ##
==========================================
+ Coverage 48.68% 48.81% +0.13%
==========================================
Files 65 66 +1
Lines 20268 20355 +87
Branches 4896 4883 -13
==========================================
+ Hits 9867 9937 +70
- Misses 9141 9161 +20
+ Partials 1260 1257 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broken og:url results in a big "Error" when sharing the donation page on Facebook.