Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nutri-Score A to B threshold and olive oils #9190

Merged
merged 4 commits into from
Oct 25, 2023
Merged

fix: Nutri-Score A to B threshold and olive oils #9190

merged 4 commits into from
Oct 25, 2023

Conversation

stephanegigandet
Copy link
Contributor

  • we had a wrong A to B threshold for food products that are not fats
  • olive oil / avocado oil should be counted as fruits/vegetables/legumes when a product is in the fats category
  • more tests

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 25, 2023 10:18
@github-actions github-actions bot added 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Food.pm nutriscore labels Oct 25, 2023
alexgarel
alexgarel approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Oct 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@9a0bfba). Click here to learn what that means.
The diff coverage is 76.47%.

@@           Coverage Diff           @@
##             main    #9190   +/-   ##
=======================================
  Coverage        ?   47.90%           
=======================================
  Files           ?       65           
  Lines           ?    20211           
  Branches        ?     4911           
=======================================
  Hits            ?     9683           
  Misses          ?     9272           
  Partials        ?     1256
Files Coverage Δ
lib/ProductOpener/Food.pm 70.83% <100.00%> (ø)
lib/ProductOpener/Ingredients.pm 92.57% <100.00%> (ø)
lib/ProductOpener/Nutriscore.pm 68.34% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet merged commit 4f04c19 into main Oct 25, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the nutriscore-v2-fix branch October 25, 2023 14:29
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Food.pm 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 💥 Merge Conflicts 💥 Merge Conflicts 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @codecov-commenter @alexgarel