Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Differentiate between rtl and ltr for the image position #5654

Merged
merged 1 commit into from
Sep 12, 2021
Merged

fix: Differentiate between rtl and ltr for the image position #5654

merged 1 commit into from
Sep 12, 2021

Conversation

hangy
Copy link
Member

@hangy hangy commented Sep 11, 2021 •
edited by teolemon
Loading

Description: Use the right position as the anchor when a RTL language is selected.

@hangy hangy added 🌐 i18n Regarding software localization frontend JavaScript labels Sep 11, 2021
@hangy hangy self-assigned this Sep 11, 2021
@hangy hangy requested a review from a team as a code owner September 11, 2021 22:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hangy hangy added the RTL label Sep 12, 2021
@hangy hangy merged commit c88ca2e into main Sep 12, 2021
@hangy hangy deleted the rtl-js branch September 12, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@hangy hangy

Labels
frontend 🌐 i18n Regarding software localization JavaScript RTL
Projects
Right-to-Left support accross Open Food Facts
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangy @teolemon